Adopt narrow helper exception boundaries#609
Merged
Merged
Conversation
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maintainer adoption of four small Spark Compete source PRs that narrow helper exception handling without changing trust boundaries.
Source PR credit:
read_json/read_tomlcatch parse and OS errors instead of broadException.subprocess.SubprocessError/OSError.OSError.No participant credit should be assigned to this maintainer adoption PR itself.
Verification
python -m pytest tests\\test_system_map.py -q -k json_toml_git_spawner_tracepython -m pytest tests\\test_cli.py -q -k security_revoke_all_os_errorpython -m pytest tests\\test_system_map.py -qpython -m pytest tests\\test_cli.py -qpython -m compileall srcgit diff --checkpython -m spark_cli.cli verify --registry-pins --jsonRisk
Low. This narrows catches around expected parse, IO, subprocess, and SQLite-adjacent support paths, with regression tests. It does not change installer metadata, registry pins, scoring, secrets, auth, sandbox policy, provider behavior, or network allow/deny rules.