[r24] Adopt CLI provider and module reliability fixes#748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spark doctor llm/ provider callsspark.tomlmanifests as clear CLI errorsok: trueto providers-list JSON and use JSONokfor provider/recommend exit codesSpark Compete source PRs credited
ok/ exit-code behaviorVerification
PYTHONPATH=src python -m pytest tests/test_cli.py -k "load_module or openai_compatible_chat_completion or cmd_providers_list_json or cmd_recommend_llms_json" -qPYTHONPATH=src python -m pytest tests/test_cli.py -k "provider or recommend or load_module or spark_toml or openai_compatible_chat_completion" -q