Skip to content

fix(cli): preserve update_module_source git stderr on cp1252 Windows consoles across all 5 git calls #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4gjnbzb4zf-sudo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(cli): preserve update_module_source git stderr on cp1252 Windows consoles across all 5 git calls #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73cc16a
fix(cli): preserve update_module_source git stderr on cp1252 Windows …
4gjnbzb4zf-sudo Jun 4, 2026
2417e5b
chore(registry): refresh blessed module pins to current HEADs
4gjnbzb4zf-sudo Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,88 +2,88 @@
"modules": {
"spark-researcher": {
"source": "https://github.com/vibeforge1111/spark-researcher",
"commit": "44743cacee7646823d2addf8aa188f2f51364955",
"commit": "972b1679e1b736741107c74822e3c15892ab4bd5",
"require_signed_commit": false,
"blessed": true,
"summary": "Research, advisory, memory packet, and domain-chip authoring runtime for Spark",
"attestation": {
"type": "git-commit-pin-v1",
"source": "https://github.com/vibeforge1111/spark-researcher",
"commit": "44743cacee7646823d2addf8aa188f2f51364955"
"commit": "972b1679e1b736741107c74822e3c15892ab4bd5"
}
},
"spark-character": {
"source": "https://github.com/vibeforge1111/spark-character",
"commit": "dc85fc8a85c42cde764a80a30d9ada7807a545f2",
"commit": "c5acaacf085b84325aefd3ec34a773f90e743635",
"require_signed_commit": false,
"blessed": true,
"summary": "Persona, voice consistency, scoring, and opt-in character evolution runtime for Spark",
"attestation": {
"type": "git-commit-pin-v1",
"source": "https://github.com/vibeforge1111/spark-character",
"commit": "dc85fc8a85c42cde764a80a30d9ada7807a545f2"
"commit": "c5acaacf085b84325aefd3ec34a773f90e743635"
}
},
"spark-telegram-bot": {
"source": "https://github.com/vibeforge1111/spark-telegram-bot",
"commit": "fefcd56220e45f6b0c709c652cf38fc10ea5d1f6",
"commit": "597b33a19da7b5cdfc4d9c26d50a3d8c6938a777",
"verify_ref": "refs/heads/main",
"require_signed_commit": false,
"blessed": true,
"summary": "Telegram ingress gateway for the Spark starter stack",
"attestation": {
"type": "git-commit-pin-v1",
"source": "https://github.com/vibeforge1111/spark-telegram-bot",
"commit": "fefcd56220e45f6b0c709c652cf38fc10ea5d1f6"
"commit": "597b33a19da7b5cdfc4d9c26d50a3d8c6938a777"
}
},
"spark-intelligence-builder": {
"source": "https://github.com/vibeforge1111/spark-intelligence-builder",
"commit": "7442cb476f72a4deedf2a90fc4407bb0b78110df",
"commit": "22cebe0bd83e785ed3f32c98495c0fbd13c9eec5",
"require_signed_commit": false,
"blessed": true,
"summary": "Spark runtime core for identity, memory, and routing",
"attestation": {
"type": "git-commit-pin-v1",
"source": "https://github.com/vibeforge1111/spark-intelligence-builder",
"commit": "7442cb476f72a4deedf2a90fc4407bb0b78110df"
"commit": "22cebe0bd83e785ed3f32c98495c0fbd13c9eec5"
}
},
"domain-chip-memory": {
"source": "https://github.com/vibeforge1111/domain-chip-memory",
"commit": "aae23128776a129decefb4fca98ad6915bf179f8",
"commit": "3ef975db30bd3b1c0e51b251683669147c6884d1",
"require_signed_commit": false,
"blessed": true,
"summary": "Default memory substrate, benchmark pack, and Telegram memory-check chip",
"attestation": {
"type": "git-commit-pin-v1",
"source": "https://github.com/vibeforge1111/domain-chip-memory",
"commit": "aae23128776a129decefb4fca98ad6915bf179f8"
"commit": "3ef975db30bd3b1c0e51b251683669147c6884d1"
}
},
"spark-voice-comms": {
"source": "https://github.com/vibeforge1111/spark-voice-comms",
"commit": "f9bbd8212a866b7b975b0afacbb46ea5fae402df",
"commit": "21a9467e9bd4eebd54b06a72a4c21afcfcd316ee",
"require_signed_commit": false,
"blessed": true,
"summary": "Speech I/O chip for Spark voice transcription, provider onboarding, and spoken replies",
"attestation": {
"type": "git-commit-pin-v1",
"source": "https://github.com/vibeforge1111/spark-voice-comms",
"commit": "f9bbd8212a866b7b975b0afacbb46ea5fae402df"
"commit": "21a9467e9bd4eebd54b06a72a4c21afcfcd316ee"
}
},
"spawner-ui": {
"source": "https://github.com/vibeforge1111/vibeship-spawner-ui",
"commit": "3a9458dfb67adee7e2a0e1e503d68317bd0af8bd",
"commit": "4e81ed21a4e14c735312f56b54f340c9f59ffffa",
"verify_ref": "refs/heads/main",
"require_signed_commit": false,
"blessed": true,
"summary": "Execution plane and local dashboard for the Spark starter stack",
"attestation": {
"type": "git-commit-pin-v1",
"source": "https://github.com/vibeforge1111/vibeship-spawner-ui",
"commit": "3a9458dfb67adee7e2a0e1e503d68317bd0af8bd"
"commit": "4e81ed21a4e14c735312f56b54f340c9f59ffffa"
}
}
},
Expand Down
12 changes: 12 additions & 0 deletions src/spark_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,8 @@ def update_module_source(module: Module) -> tuple[bool, str]:
git_command("-C", str(module.path), "status", "--porcelain"),
capture_output=True,
text=True,
encoding="utf-8",
errors="replace",
)
if status.returncode != 0:
return False, summarize_command_output(status)
Expand All @@ -736,6 +738,8 @@ def update_module_source(module: Module) -> tuple[bool, str]:
git_command("-C", str(module.path), "rev-parse", "HEAD"),
capture_output=True,
text=True,
encoding="utf-8",
errors="replace",
)
if current.returncode != 0:
return False, summarize_command_output(current)
Expand All @@ -747,6 +751,8 @@ def update_module_source(module: Module) -> tuple[bool, str]:
git_command("-C", str(module.path), "fetch", "--depth=1", "origin", pinned_commit),
capture_output=True,
text=True,
encoding="utf-8",
errors="replace",
)
if fetch.returncode != 0:
return False, summarize_command_output(fetch)
Expand All @@ -756,6 +762,8 @@ def update_module_source(module: Module) -> tuple[bool, str]:
git_command("-C", str(module.path), "verify-commit", pinned_commit),
capture_output=True,
text=True,
encoding="utf-8",
errors="replace",
)
if verify.returncode != 0:
return False, summarize_command_output(verify)
Expand All @@ -764,6 +772,8 @@ def update_module_source(module: Module) -> tuple[bool, str]:
git_command("-C", str(module.path), "checkout", "--detach", pinned_commit),
capture_output=True,
text=True,
encoding="utf-8",
errors="replace",
)
if checkout.returncode != 0:
return False, summarize_command_output(checkout)
Expand All @@ -772,6 +782,8 @@ def update_module_source(module: Module) -> tuple[bool, str]:
git_command("-C", str(module.path), "rev-parse", "HEAD"),
capture_output=True,
text=True,
encoding="utf-8",
errors="replace",
)
if resolved.returncode != 0:
return False, summarize_command_output(resolved)
Expand Down
Loading