fix: force text track updateDisplay to recalculate on playerresize

[Frenzie]

Otherwise processCues reuses the old position and size.

Description

1. Go to https://legacy.videojs.org/advanced/?video=bipbop-advanced
2. Activate the cc1 caption track
3. Pause to more easily see the effect
4. Activate fullscreen or resize the window such that the player resizes
5. The caption position and size isn't recalculated

Specific Changes proposed

Force recalculation in vtt.js in this function:

  // Determine if we need to compute the display states of the cues. This could
  // be the case if a cue's state has been changed since the last computation or
  // if it has not been computed yet.
  function shouldCompute(cues) {
    for (var i = 0; i < cues.length; i++) {
      if (cues[i].hasBeenReset || !cues[i].displayState) {
        return true;
      }
    }
    return false;
  }

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Change has been verified in an actual browser (Chrome, Firefox, IE)
  • Unit Tests updated or fixed
  • Docs/guides updated
  • Example created (starter template on JSBin)
  • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
  • Has no changes to JSDoc which cause npm run docs:api to error
• Reviewed by Two Core Contributors

[welcome]

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

• Run npm run lint -- --errors locally to catch formatting errors earlier.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.32%. Comparing base (9d2101e) to head (0e095b3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/js/tracks/text-track-display.js	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9160      +/-   ##
==========================================
- Coverage   84.32%   84.32%   -0.01%     
==========================================
  Files         120      120              
  Lines        8153     8157       +4     
  Branches     1964     1967       +3     
==========================================
+ Hits         6875     6878       +3     
- Misses       1278     1279       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mister-ben]

I can't reproduce the issue on Chrome or Firefox. It's resizing without your change. Is there anything more to know to reproduce that?

[Frenzie]

That means you selected any of the subtitle tracks, not the cc1 caption track. ;-)

It happens in all browsers because the issue is that it purposefully skips computing the size/position when resizing.

[mister-ben]

Sorry, I see now!

[Frenzie]

No problem and thanks! While I have your attention, would you mind taking a look at my PRs against vtt.js?

• Improve font size calculation for vertical video vtt.js#69
• Avoid infinite placement loop when lineHeight is 0 vtt.js#71