Added Behdad Analui's solution#63
Open
banalui wants to merge 5 commits intovikingeducation:masterfrom
Open
Conversation
…at data was already available with previous get
remis1889
reviewed
Apr 16, 2017
remis1889
left a comment
remis1889
left a comment
There was a problem hiding this comment.
Reviewed. Too many classes than necessary. Should be refactored.
| @all_jobs = [] | ||
| end | ||
|
|
||
| def extract_job_info(search_result) |
There was a problem hiding this comment.
all the methods except scrape and save should be private
|
|
||
| class PageFormatter | ||
|
|
||
| def self.get_page_from(url) |
There was a problem hiding this comment.
This class is not necessary. get_page_from can be a method in DiceWebScraper
| extract_job_info cur_page | ||
| end | ||
|
|
||
| def filter_result(search_result) |
There was a problem hiding this comment.
This method can be removed since all it does is call another method. You may as well call filter_segment directly from scrape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.