Conversation
muglug
approved these changes
Jun 30, 2022
Collaborator
|
Mind fixing the Psalm errors? |
Fixed most of Psalm issues Boolean values are internally stored as integers
Author
|
I fixed all Psalm issues but one. I understand why Psalm is complaining about I would appreciate a helping hand and getting an explanation why I see such discrepancy. |
Contributor
|
@SirPL I know it's been a while, so not sure if you still care to work on this, but there's no discrepancy. I think Psalm should will be satisfied if you just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From MySQL perspective the
booleanis an alias fortinyint.