Open
Conversation
tmazza
changed the title
tmazza
changed the title
tmazza
changed the title
tmazza
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que mudou
Assinatura do método de
product_items()no recursoSubscriptionalterada de acordo com o que é mostrado na documentação documentação. Não há quebra no uso atual do método.Motivação
Para tornar possível a buscar com paginação dos items de 1 assinatura conforme documentação. Em https://vindi.github.io/api-docs/dist/#/subscriptions/getV1SubscriptionsIdProductItems
Solução proposta
Método
product_items()recebe parâmetro opcional para aplicação de paginação, conforme assinatura do métodoall()deResourceComo testar
Testes unitários. Ou utilizar rota em
/v1/subscriptions/{id}/product_itemscom paginação.