#102 vLLM subclass implementation as inference backend and example updated.#107
Open
solankinitish wants to merge 1 commit into
Open
#102 vLLM subclass implementation as inference backend and example updated.#107solankinitish wants to merge 1 commit into
solankinitish wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102
Problem
The existing
VLLMimplementation (added in #106) was incomplete — it importedhttpxmid-class to fetchmax_model_lenfrom the vLLM server at init time, making instantiation fail without a live server and introducing an undeclared dependency.Changes
VLLMas a clean subclass following the same pattern asOllama—api_baseandmax_tokenspassed explicitly, no network calls at initmax_tokensdefaults to 4096 and can be overridden by the user to match their model's context lengthLLMinfrastructureexamples/Getting_started.ipynbUsage