Skip to content

Add offset-0#2

Open
oBusk wants to merge 1 commit intovivid-web:masterfrom
oBusk:patch-1
Open

Add offset-0#2
oBusk wants to merge 1 commit intovivid-web:masterfrom
oBusk:patch-1

Conversation

@oBusk
Copy link
Copy Markdown

@oBusk oBusk commented Aug 29, 2017

Sometimes an item will have an offset on small screens, for example

<div class="col col--xs-6 col--xs-offset-3"></div>

This will mean that this item is centered.

Let's imagine that on a bigger screen, the item will be smaller, to fit next to an another column for example.

The offset will remain even on higher breakpoints.

This change simply also creates offset-0 to reset the offset on any specific breakpoint.

<div class="col col--xs-6 col--xs-offset-3 col--md-4 col--md-offset-0"></div>

@petervmeijgaard
Copy link
Copy Markdown
Member

Hi @oBusk!

Thanks for the issue, I've applied the fix in the latest version, which is not public yet.
My sincere apologies for the late response. I've been wanting to refactor the grid for a long time now, but I couldn't find the time to do so.
Yesterday I've already updated the Stylus and SASS variant, but applying the same code for the Less variant is kinda tricky. Less mixins won't play nice...

You can download one of these projects by using npm install @vivid-web/flexboxgrid-stylus. Please have a little bit more patience before I fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants