Skip to content

fix db.close() for new interface#130

Merged
spytheman merged 1 commit intovlang:masterfrom
kbkpbot:fix-db-close
Jun 26, 2025
Merged

fix db.close() for new interface#130
spytheman merged 1 commit intovlang:masterfrom
kbkpbot:fix-db-close

Conversation

@kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Jun 26, 2025

As PR (vlang/v#24780) modify the db close() to using the pool interface.

@medvednikov
Copy link
Member

Should this be merged after the V fix?

Error: src/main.v:28:14: error: unexpected or block, the function close does not return an Option or a Result
26 |
27 | defer {
28 | db.close() or {}
| ~~~~~
29 | }

@spytheman spytheman closed this Jun 26, 2025
@spytheman spytheman reopened this Jun 26, 2025
@spytheman spytheman merged commit 6c122b7 into vlang:master Jun 26, 2025
2 of 4 checks passed
@JalonSolov
Copy link

Should this be merged after the V fix?

Error: src/main.v:28:14: error: unexpected or block, the function close does not return an Option or a Result 26 | 27 | defer { 28 | db.close() or {} | ~~~~~ 29 | }

Classic chicken/egg problem. This won't pass the CI clean until V is updated, but V won't pass CI clean until this is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants