This repository was archived by the owner on Mar 27, 2023. It is now read-only.
Add VirtualMachinePublishRequest reason.#110
Open
yi0909 wants to merge 2 commits intovmware-archive:masterfrom
Open
Add VirtualMachinePublishRequest reason.#110yi0909 wants to merge 2 commits intovmware-archive:masterfrom
yi0909 wants to merge 2 commits intovmware-archive:masterfrom
Conversation
This change includes - Introduces a field Attempt to the VirtualMachinePublishRequestStatus. Attempt represents the number of times VM publish request has been attempted. - Introduce a field LastAttemptTime to the status, which represents the time when the last attempt was sent. - Update VirtualMachinePublishRequestTarget comment.
yi0909
force-pushed
the
topic/yijiang/add-vmpub-condition-reason
branch
from
23afcba to
d3ae311
Compare
This change includes - Introduce VirtualMachinePublishRequest reason. - Update MarkCondition function. It should set the reason to the input parameter if it is not empty.
yi0909
force-pushed
the
topic/yijiang/add-vmpub-condition-reason
branch
from
d3ae311 to
1596fe7
Compare
zyiyi11
reviewed
Oct 26, 2022
Contributor
zyiyi11
left a comment
zyiyi11
left a comment
There was a problem hiding this comment.
Overall LGTM. Just VirtualMachinePublishRequestUploadingReason = "Uploading" seems odd, it's more like a phase.
bryanv
reviewed
Oct 28, 2022
|
|
||
| // VirtualMachinePublishRequestSourceVMNotCreatedReason (Severity=Error) documents that the source VM | ||
| // hasn't been fully created yet. | ||
| VirtualMachinePublishRequestSourceVMNotCreatedReason = "SourceVMNotCreated" |
Contributor
There was a problem hiding this comment.
Do we have sufficient context to determine between this reason and the UniqueIDNotReady below? Once the VM is created, we have the MoID/UniqueID. What does "fully created" mean in the context here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change includes