fix: existing template detection in vsphere-template post-processor

[karelvanhecke]

Summary

Improves the logic for finding a template VM by adding an explicit check to ensure the returned VM is actually a template. If the found VM is not a template, the function now returns nil instead of the VM.

In step_mark_as_template.go, the findTemplate function now checks if the located VM is a template using IsTemplate, and only returns the VM if it is indeed a template. If not, it returns nil, preventing incorrect handling of non-template VMs.

Type

• fix: Bug Fix
• feat: Feature or Enhancement
• docs: Documentation
• refactor: Refactoring
• chore: Build, Dependencies, Workflows, etc.
• other: Other (Please describe.)

Breaking Changes?

• Yes, there are breaking changes.
• [x ] No, there are no breaking changes.

Tests

• Tests have been added or updated.
• Tests have been completed.

Output:

Documentation

• Documentation has been added or updated.

Issue References

Closes #728

Release Note

- Fix existing template detection in `vsphere-template` post-processor.

Additional Information

[tenthirtyam]

@karelvanhecke - thanks for this contribution. I can merge this once your commit has a verified signature. You can refer to my blog post Signing Your Git Commits: From Zero to Verified to amend and sign the commit.

Ryan Johnson, Broadcom
Customer sidekick. Open source developer.

[tenthirtyam]

Marked as draft until the commit(s) have verified signatures.

[karelvanhecke]

@tenthirtyam I've signed my commit.