Fix for black illegible view and convenience method #1
Open
dominickm wants to merge 3 commits intovojto:masterfrom
Open
Fix for black illegible view and convenience method #1dominickm wants to merge 3 commits intovojto:masterfrom
dominickm wants to merge 3 commits intovojto:masterfrom
Conversation
added 3 commits
June 22, 2012 23:45
…; if it doesn't it will load the build in PageScheme and PageSyntax. This fixes an issue where a user might see a black (illegible) textView in certain rare cases.
… this does not work with Nibs
…ibs, however, if loaded from a Nib the previous solution will be used -- preventing a crash
Owner
|
Hi, sorry for not responding, I'll try to merge this in before the weekend! Thanks! |
Author
|
Great. glad you like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vojito,
I have been playing with RKSyntaxView and added a small fix for an issue I found: the issue was that if you did not explicitly call loadSyntax you might get a black view that you could not read.
More importantly, I added a convenience init that allows default schemes and syntax files to be set on init and will try to load those if the load methods are not specifically called. One issue is that my convenience method doesn't work with Nibs, so there is a check that will load your @"PageScheme" and @"PageSyntax" if all else fails. I am not really interested in making it work with nibs... but if you need it to I can look into it.
If you are interested in this type of thing, I offer you this pull. Have fun! Thanks for the great lib!