Refactor ownership cleanup and content slot management#7
Merged
volynetstyle merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
- Updated the `addCleanup` function to handle cleanup functions more efficiently by using a unified `Cleanup` type. - Improved error handling in cleanup invocation with a dedicated `invokeCleanup` function. - Simplified the `runCleanups` function to streamline cleanup execution and error reporting. - Refactored the `createContentSlot` function to enhance clarity and reduce redundancy in state management. - Introduced unmounting logic for current content in `unmountCurrent` to ensure proper cleanup of mounted nodes. - Added tests for ownership lifecycle to verify the correct behavior of cleanup and disposal processes, including error handling during cleanup. - Implemented a new runtime scheduler interface to manage flushing of reactive work and commit processes. - Added performance benchmarks for various reactive scenarios to assess efficiency and responsiveness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addCleanupfunction to handle cleanup functions more efficiently by using a unifiedCleanuptype.invokeCleanupfunction.runCleanupsfunction to streamline cleanup execution and error reporting.createContentSlotfunction to enhance clarity and reduce redundancy in state management.unmountCurrentto ensure proper cleanup of mounted nodes.