Open
Conversation
This is to avoid the wrong idea that flex-wrap without defined space of items it affects is working "incorrectly".
Remove a step of abstraction about cards "knowing" so the hint directly references defining space of cards. Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
07 flex layout 2: add additional hint for cards requiring space
04 flex information: fix the solution to fit the self-check
Rather than tailoring contribution guides to the repo they reside in, I decided to make one that was more general and could be simply copy+pasted into each repo where necessary. This can require less upkeep when changes are made (simply copy+paste across all repos rather than needing to comb through and copy+paste only specific sections that were updated). Tailored instructions will be added later, such as instructions for running TOP locally, lesson writing guide (TBA), etc.
flex/03-flex-header-2: fixed links not leading to desired URL
… to card class in solution.css (#501) * Add gap to container instead of adding margin to card * Increasing gap to 32px * Increase padding in container class
README: add more info about git workflow and not to open PR
Since commit 65b831b changed `container`'s padding, the instruction of padding in `README.md` should be changed as well.
Since commit 061fe0a replaced the margin with gap in solution.css, the margin should be deleted in style.css as well.
README: Change style of PR note
… to solve Isuue#545
02-margin-and-padding-2: Updated solution.css and desired-outcome.png to solve Issue#545
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
Update desired-outcome.png to match solution code. Close #570
#566) Signed-off-by: Namit Arjaria <namitarjaria25@gmail.com>
Original repo structure was prone to people forgetting exactly what was instructed, leading them to do the wrong exercises (especially when they have momentum from studying). The new structure puts exercises in groups (based around their respective lesson assignments) which are in turn placed in course folders. More intuitive organisation.
Not all rows would grow taller on narrowing.
README previously said all possible solutions were provided which is inaccurate and not desirable either.
This is not the 'final' exercise for CSS Foundations, as README suggests. Because '01-margin-and-padding-1' and '02-margin-and-padding-2' are the last exercises for CSS Foundations, this README's wording needs to be updated for accuracy.
01-cascade-fix: Fix typo in README
Placeholder comment was added to intro exercise 4 but not the others
Some content was changed in a previous PR but missed some stuff, leaving some confusing instructions and comments in.
Stale since curriculum was previously updated to recommend Live Preview over Live Server.
Pixel matching not the point of the exercise
1. ESLint not installed as a dependency 1. Would therefore only be useful for IDE ESLint extensions, and it's a legacy config format anyway which may not work in current/future versions 1. Not sure how ESLint is valuable here anyway, given 99% of exercises contain no JS (only 2 exercises right now, unlikely to be many more in the future) and what JS does exist is extremely minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.