chore(ci): remove dockerhub-description continue-on-error workaround + document scope#106
Merged
Merged
Conversation
…+ document scope Closes the 'borç' from .planning/TODO.md: the Sync Docker Hub description step in release.yml has been carrying continue-on-error: true since the very first release because DOCKERHUB_TOKEN lacked repo:write_metadata. The workaround masked a recoverable secret- misconfiguration: every release silently lost the Docker Hub overview sync, leaving the readme-filepath upload as a no-op. Now: - release.yml requires the step to succeed; a 403 surfaces as a CI failure on tag push, not a quiet skip. - docs/RELEASE.md §1 lists the three required token scopes (repo:read, repo:write, repo:write_metadata) and where to set them on Docker Hub. Operators that have already widened the token scope see no behaviour change. Operators that hadn't will get a hard CI failure on the next v* tag push, which is the correct signal to widen the scope once and forget about it.
voyvodka
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tur 6a — closes one of the two pre-B1 backlog items from
.planning/TODO.md.The
Sync Docker Hub descriptionstep inrelease.ymlhas been carryingcontinue-on-error: truesince the very first release becauseDOCKERHUB_TOKENlacked therepo:write_metadatascope. The workaround masked a recoverable secret-misconfiguration: every release silently lost the Docker Hub overview sync.Changes
.github/workflows/release.yml— removedcontinue-on-error: true, replaced the inline comment with a pointer todocs/RELEASE.md §1.docs/RELEASE.md §1—DOCKERHUB_TOKENrow now lists the three required scopes (repo:read,repo:write,repo:write_metadata) and where to set them (Docker Hub → Account Settings → Personal Access Tokens).Behaviour after merge
v*tag push will hard-fail at this step with a403. That's the correct signal to widen the scope once and forget about it. The image push above this step is already committed at that point — the failure is recoverable without re-tagging (re-run the failed job after fixing the token).Test plan
v*tags, so this PR's CI exercises the YAML parse only).