Choice inference#847
Merged
Merged
Conversation
quickbeam123
approved these changes
Apr 29, 2026
MichaelRawson
approved these changes
Apr 30, 2026
Contributor
MichaelRawson
left a comment
MichaelRawson
left a comment
There was a problem hiding this comment.
Basically good - just one question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up the choice inferences, merging the relevant changes from the HOL branch, and adding some unit tests.
HOL regression (with choice reasoning enabled,
-chr on), shows a bit of improvement, mostly because loose DB indices are not bound and hence some errors are avoided:Discount
run 0 unsat: 2240 (0) sat: 1 (0) cputime: 8449.42 s instructions: 41927093 Mi memory: 112563.93 MB
run 1 unsat: 2252 (12) sat: 1 (0) cputime: 8696.54 s instructions: 44143448 Mi memory: 117507.94 MB
Otter
run 0 unsat: 2212 (1) sat: 1 (0) cputime: 8943.08 s instructions: 42962767 Mi memory: 138522.92 MB
run 1 unsat: 2220 (9) sat: 1 (0) cputime: 9103.20 s instructions: 44816098 Mi memory: 141062.58 MB
Once review is done, I would like to move the
ChoiceandChoiceDefinitionISEtoInferences/HOL.