Added CPUS_PER_TASK and a jupyterlab.sbatch#44
Open
emarti wants to merge 2 commits intovsoch:masterfrom
Open
Conversation
New parameter CPUS_PER_TASK specificies the number of cpus requested.
File sbatches/sherlock/jupyterlab.sbatch enables more modern jupyter lab notebooks
Owner
|
This looks great! Two quick checks:
|
Author
|
Owner
Gotcha. In this case, we don't want to set a default to be 1, because it will break the default behavior. Let's keep the variable unset, and then only add it to the command if it's defined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes: First, I added jupyterlab.sbatch so we can use jupyter lab notebooks instead of the modern ones. Second, I added a CPUS_PER_TASK parameter in param.sh so we can change the number of CPUs requested.