Merged
Conversation
Professional documentation with architecture, inventory, runbooks, and templates: **Architecture:** - network-architecture.md: Network topology with Mermaid diagrams - VLAN configuration (Servers, Management, Clients, IoT, Quarantine) - IP address ranges and subnetting - Firewall rules and port assignments - DNS configuration **Inventory:** - servers.md: Comprehensive server inventory - Physical servers with specs - Virtual machines - Docker containers - Network devices - Service mappings and maintenance windows **Runbooks:** - incident-response.md: Incident handling procedures - P0-P3 severity levels with response times - Diagnostic commands and recovery steps - Escalation paths - Communication templates - Post-mortem template **Templates:** - change-request.md: Change management template - Implementation plan - Risk assessment - Rollback procedures - Approval workflow All documentation is bilingual (English/Hungarian). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Reviewer's GuideAdds a new Homelab documentation package that formalizes network architecture, server inventory, and operational processes using bilingual (EN/HU) markdown docs, including an incident‑response runbook and a structured change‑request template. Sequence diagram for P0 incident response using the new runbooksequenceDiagram
actor Admin
participant Monitoring as MonitoringSystem
participant Runbook as IncidentRunbook
participant Infra as HomelabInfrastructure
Monitoring->>Admin: Send critical alert (P0)
Admin->>Runbook: Identify severity level and required response time
Admin->>Infra: Run diagnostic commands (ping, systemctl, docker, df, free, top)
Infra-->>Admin: Return health and status information
Admin->>Infra: Restart Prometheus and Grafana via docker-compose
Infra-->>Admin: Updated service status and health endpoints
Admin->>Infra: Collect logs (docker-compose logs, journalctl, syslog)
Infra-->>Admin: Log output for analysis
alt Issue resolved within 15 minutes
Admin->>Runbook: Use incident closing template
Admin->>Monitoring: Confirm alerts cleared
Admin->>Admin: Document root cause and lessons learned
else Not resolved within 15 minutes
Admin->>Runbook: Follow escalation matrix
Admin->>BackupAdmin: Escalate with incident report
BackupAdmin->>Infra: Continue troubleshooting and recovery
end
Flow diagram for the new change request processflowchart TB
A[Start change idea] --> B[Copy change request template]
B --> C[Fill Change Information and Description]
C --> D[Describe Current State and Desired State]
D --> E[Select Change Type]
E --> F[Write Implementation Plan and Commands]
F --> G[Define Verification Points]
G --> H[Create Rollback Plan]
H --> I[Assess Risks and Mitigations]
I --> J[Propose Schedule and Maintenance Window]
J --> K[Define Notifications and Stakeholders]
K --> L[Pre-change checklist]
L --> M[Submit for approval]
M -->|Approved| N[Execute change and record Execution Log]
M -->|Rejected or Needs changes| O[Revise change request]
O --> C
N --> P[Post-change checklist]
P --> Q[Notify stakeholders and update documentation inventory]
Q --> R[Close change and set Status to CLOSED]
R --> S[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The network documentation mixes concepts that aren’t fully defined (e.g. firewall rules reference a DMZ, but there’s no DMZ VLAN or IP range defined), so it would help to either add a DMZ segment to the IP/VLAN table or remove DMZ-specific rules to keep the design consistent.
- In the incident response runbook, the recovery steps mix different deployment styles for Prometheus/Grafana (
systemctlunits anddocker-composecontainers, including a placeholder/path/to/docker-compose.yml), so consider aligning on the actual deployment method and replacing placeholders with concrete or clearly parameterized examples. - Some references and ports appear generic or possibly copy-pasted (e.g.
Microsoft Graph APIin the references andDockerexposed on 2376 without context), so it may be worth pruning or clarifying these to match the actual homelab services and security assumptions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The network documentation mixes concepts that aren’t fully defined (e.g. firewall rules reference a DMZ, but there’s no DMZ VLAN or IP range defined), so it would help to either add a DMZ segment to the IP/VLAN table or remove DMZ-specific rules to keep the design consistent.
- In the incident response runbook, the recovery steps mix different deployment styles for Prometheus/Grafana (`systemctl` units and `docker-compose` containers, including a placeholder `/path/to/docker-compose.yml`), so consider aligning on the actual deployment method and replacing placeholders with concrete or clearly parameterized examples.
- Some references and ports appear generic or possibly copy-pasted (e.g. `Microsoft Graph API` in the references and `Docker` exposed on 2376 without context), so it may be worth pruning or clarifying these to match the actual homelab services and security assumptions.
## Individual Comments
### Comment 1
<location> `6-homelab-docs/runbooks/incident-response.md:159` </location>
<code_context>
+STATUS: [INVESTIGATING / IDENTIFIED / RESOLVING / RESOLVED]
+```
+
+### Incidenzárás / Incident Closing
+
+```
</code_context>
<issue_to_address>
**issue (typo):** Typo in Hungarian section title: use "Incidenszárás" instead of "Incidenzárás".
This keeps the Hungarian terminology consistent with “Incidensnyitás” and removes a visible spelling error in the heading.
```suggestion
### Incidenszárás / Incident Closing
```
</issue_to_address>
### Comment 2
<location> `6-homelab-docs/templates/change-request.md:80` </location>
<code_context>
+
+## Kockázat Értékelés / Risk Assessment
+
+### Kockázat Szint / Risk Level
+- [ ] Alacsony / Low - Minimális hatás, könnyen visszaállítható
+- [ ] Közepes / Medium - Korlátozott hatás, visszaállítható
</code_context>
<issue_to_address>
**suggestion (typo):** More idiomatic Hungarian would be "Kockázati Szint".
Consider changing the heading to "Kockázati Szint / Risk Level" for more natural Hungarian phrasing.
```suggestion
### Kockázati Szint / Risk Level
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Összefoglaló
🇬🇧 English
Professional homelab documentation with architecture diagrams, inventory, runbooks, and templates:
Architecture Documentation:
Inventory Management:
Runbooks:
Templates:
🇭🇺 Magyar
Professzionális homelab dokumentáció architektúra diagramokkal, leltárral, runbook-okkal és sablonokkal.
Features
Test Plan / Tesztterv
🤖 Generated with Claude Code
Summary by Sourcery
Add structured bilingual homelab documentation covering network architecture, inventory, incident response, and change management templates.
New Features: