Skip to content

update action to run on node22#4

Closed
waheedahmed wants to merge 2 commits into
mainfrom
waheed/nodejs-upgrade
Closed

update action to run on node22#4
waheedahmed wants to merge 2 commits into
mainfrom
waheed/nodejs-upgrade

Conversation

@waheedahmed
Copy link
Copy Markdown
Owner

This pull request introduces configuration options for merge retry logic and updates the Node.js runtime version used by the GitHub Action. The main changes are:

Merge Retry Logic:

  • Added merge-retries and merge-retry-sleep options to the configuration, allowing users to control how many times the action retries merging and the delay between retries. This provides more flexibility and robustness when handling transient merge failures.

Runtime Update:

  • Updated the Node.js runtime version for the GitHub Action from node20 to node22, ensuring compatibility with the latest features and security updates.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Action to use a newer Node.js runtime and documents new configuration inputs related to retrying merge-queue enqueue attempts.

Changes:

  • Bump the action runtime from node20 to node22 in action.yml.
  • Document merge-retries / merge-retry-sleep inputs in README.md.
  • Update the package version recorded in package-lock.json to 0.0.5.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
package-lock.json Updates the lockfile’s recorded package version to 0.0.5.
action.yml Switches the JS action runtime to node22.
README.md Adds the new retry-related inputs to the inputs table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread action.yml
Comment on lines 68 to 70
runs:
using: "node20"
using: "node22"
main: "dist/index.js"
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action runtime is being bumped to Node 22, but the repo CI workflow (.github/workflows/test.yml) still runs lint/tests on Node 20 only. To reduce the risk of Node-version-specific regressions, consider updating CI to run on Node 22 (or a matrix including both 20 and 22) so the tested runtime matches what users will run in production.

Copilot uses AI. Check for mistakes.
Comment thread README.md
| `base-branches` | Comma-separated list of allowed base branches. Empty = all branches. | `""` |
| `skip-drafts` | Skip draft pull requests. | `true` |
| `required-approvals` | Minimum approving reviews before enqueuing. `0` = rely on branch protection rules. | `0` |
| `merge-retries` | Number of times to retry enqueueing if it fails. Set to `0` to disable retry logic. | `6` |
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README uses both "enqueuing" and "enqueueing" (e.g., the label/required-approvals rows use "enqueuing", but these new rows use "enqueueing"). Consider standardizing the spelling across the README for consistency (pick one form and use it everywhere).

Suggested change
| `merge-retries` | Number of times to retry enqueueing if it fails. Set to `0` to disable retry logic. | `6` |
| `merge-retries` | Number of times to retry enqueuing if it fails. Set to `0` to disable retry logic. | `6` |

Copilot uses AI. Check for mistakes.
@waheedahmed waheedahmed force-pushed the main branch 3 times, most recently from d0690c3 to 2f0dc7e Compare April 30, 2026 14:28
@waheedahmed waheedahmed deleted the waheed/nodejs-upgrade branch April 30, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants