update action to run on node22#4
Conversation
add retry logic to the action
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Action to use a newer Node.js runtime and documents new configuration inputs related to retrying merge-queue enqueue attempts.
Changes:
- Bump the action runtime from
node20tonode22inaction.yml. - Document
merge-retries/merge-retry-sleepinputs inREADME.md. - Update the package version recorded in
package-lock.jsonto0.0.5.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package-lock.json | Updates the lockfile’s recorded package version to 0.0.5. |
| action.yml | Switches the JS action runtime to node22. |
| README.md | Adds the new retry-related inputs to the inputs table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| runs: | ||
| using: "node20" | ||
| using: "node22" | ||
| main: "dist/index.js" |
There was a problem hiding this comment.
The action runtime is being bumped to Node 22, but the repo CI workflow (.github/workflows/test.yml) still runs lint/tests on Node 20 only. To reduce the risk of Node-version-specific regressions, consider updating CI to run on Node 22 (or a matrix including both 20 and 22) so the tested runtime matches what users will run in production.
| | `base-branches` | Comma-separated list of allowed base branches. Empty = all branches. | `""` | | ||
| | `skip-drafts` | Skip draft pull requests. | `true` | | ||
| | `required-approvals` | Minimum approving reviews before enqueuing. `0` = rely on branch protection rules. | `0` | | ||
| | `merge-retries` | Number of times to retry enqueueing if it fails. Set to `0` to disable retry logic. | `6` | |
There was a problem hiding this comment.
The README uses both "enqueuing" and "enqueueing" (e.g., the label/required-approvals rows use "enqueuing", but these new rows use "enqueueing"). Consider standardizing the spelling across the README for consistency (pick one form and use it everywhere).
| | `merge-retries` | Number of times to retry enqueueing if it fails. Set to `0` to disable retry logic. | `6` | | |
| | `merge-retries` | Number of times to retry enqueuing if it fails. Set to `0` to disable retry logic. | `6` | |
d0690c3 to
2f0dc7e
Compare
This pull request introduces configuration options for merge retry logic and updates the Node.js runtime version used by the GitHub Action. The main changes are:
Merge Retry Logic:
merge-retriesandmerge-retry-sleepoptions to the configuration, allowing users to control how many times the action retries merging and the delay between retries. This provides more flexibility and robustness when handling transient merge failures.Runtime Update:
node20tonode22, ensuring compatibility with the latest features and security updates.