Merged
Conversation
- Ignore netapp.com false positive - Reduce verbosity to warn - Add debug step to emit the effective Lychee config - Explicitly pass --config and point to lychee.toml, which should pick up config changes in the same PRff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lychee quality-of-life improvements
These changes were inspired by friction I encountered in #2113 where attempting to ignore netapp.com were ignored, as well as attempts to reduce the verbosity of the Lychee check. I think that after this PR merges, future config changes in scope of a PR will be picked up.
Testing
N/A. This PR doesn't update Markdown, so most of the checks won't run.