Fix Boost audio downloads using direct MPD lookup#73
Open
brealorg wants to merge 3 commits into
Open
Conversation
3 tasks
f4132cf to
f84c821
Compare
|
I tested it and it works without issues, thanks for your efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Boost for Reddit audio retrieval for v.redd.it video downloads/shares.
The previous implementation tried to resolve the Reddit post JSON by requesting the v.redd.it base URL, following the redirected URL, and then appending /.json. Reddit currently returns a non-JSON response in this path for some videos, causing:
Failed to retrieve audio:
com.fasterxml.jackson.core.JsonParseException:
Unexpected character ('<' (code 60))
Since the intercepted request already contains the v.redd.it media base URL, this change avoids the brittle Reddit JSON lookup and fetches the DASH manifest directly from:
https://v.redd.it//DASHPlaylist.mpd
The existing MPD parser is then used to resolve the audio BaseURL.
This also fixes the parser’s bandwidth selection logic by updating maxBandwidth when a better audio representation is found, and filters the selection so it only considers audio representations.
Tested locally with Boost 1.12.12 patched through Morphe using a local Patcheddit .mpp bundle.
Before:
After: