Fix slow Giphy loading in Boost#86
Open
brealorg wants to merge 1 commit into
Open
Conversation
3 tasks
|
I tested it and it works without issues, thanks for your efforts! Hopefully it goes through soon. These issues were there foreever |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes slow Giphy loading in Boost for Reddit.
Boost currently resolves Giphy posts through its old Giphy API resolver:
api.giphy.com/v1/gifs/{gif_id}
That adds a large delay before playback starts. In testing, the same Giphy item loaded through Boost after roughly 8 seconds, while the direct Giphy MP4 URL loaded essentially instantly.
Boost already has an internal fallback method that constructs the direct MP4 URL:
https://media.giphy.com/media//giphy.mp4
This patch bypasses the slow Giphy API resolver and calls Boost's existing direct MP4 fallback instead.
Tested with:
Before:
After:
The patch is intentionally small:
GifUrlExtractorCancelable.javaGiphy API resolver using the old public Giphy API key string.x()fallback method.