Skip to content

Fix slow Giphy loading in Boost#86

Open
brealorg wants to merge 1 commit into
wchill:mainfrom
brealorg:boost-giphy-direct-mp4
Open

Fix slow Giphy loading in Boost#86
brealorg wants to merge 1 commit into
wchill:mainfrom
brealorg:boost-giphy-direct-mp4

Conversation

@brealorg

Copy link
Copy Markdown

Fixes slow Giphy loading in Boost for Reddit.

Boost currently resolves Giphy posts through its old Giphy API resolver:

api.giphy.com/v1/gifs/{gif_id}

That adds a large delay before playback starts. In testing, the same Giphy item loaded through Boost after roughly 8 seconds, while the direct Giphy MP4 URL loaded essentially instantly.

Boost already has an internal fallback method that constructs the direct MP4 URL:

https://media.giphy.com/media//giphy.mp4

This patch bypasses the slow Giphy API resolver and calls Boost's existing direct MP4 fallback instead.

Tested with:

  • Boost 1.12.12
  • Morphe Manager
  • Local Patcheddit .mpp bundle
  • Example Giphy item: 1201hONkUdpK36

Before:

  • Giphy media took several seconds to start.

After:

  • Giphy media starts essentially immediately.

The patch is intentionally small:

  • It fingerprints Boost's GifUrlExtractorCancelable.java Giphy API resolver using the old public Giphy API key string.
  • It replaces the resolver path by calling Boost's existing x() fallback method.
  • It does not add a new HTTP interceptor or new media handling logic.

@Tenny131

Copy link
Copy Markdown

I tested it and it works without issues, thanks for your efforts! Hopefully it goes through soon. These issues were there foreever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants