Skip to content

Support multiple deployments in the same namespace#234

Open
delamainer wants to merge 26 commits into
weaviate:mainfrom
delamainer:support-multiple-deployments-in-the-same-namespace
Open

Support multiple deployments in the same namespace#234
delamainer wants to merge 26 commits into
weaviate:mainfrom
delamainer:support-multiple-deployments-in-the-same-namespace

Conversation

@delamainer
Copy link
Copy Markdown

@delamainer delamainer commented May 12, 2024

Support multiple deployments in the same namespace.

Issue: #115

This feature is requested by multiple users.

@delamainer
Copy link
Copy Markdown
Author

@antas-marcin Hi, please review this pull request.

@weaviate-git-bot
Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@delamainer
Copy link
Copy Markdown
Author

I agree with the CLA.

@delamainer
Copy link
Copy Markdown
Author

@antas-marcin Is there any chance that this feature will be adopted?

@antas-marcin
Copy link
Copy Markdown
Collaborator

@delamainer I will try to find time to look into your PR this week, sorry for the delay on this.

@kfkonrad
Copy link
Copy Markdown

@delamainer please consider rebasing and fixing conflicts
@antas-marcin please consider reviewing this PR once the conflicts are fixed

@bender316
Copy link
Copy Markdown

Any chance this PR might come back to live!? While integration weaviate into our umbrella chart I came across the same issue.

I would advice against using .Release.Name as the name prefix. This woul mean that you can have only one weaviate instance per release. Maybe there is never a situation where this is needed but defining a name template for it like the Bitnami charts are doing it (see [1] and [2]) would be better.

[1] https://github.com/bitnami/charts/blob/main/bitnami/postgresql/templates/primary/statefulset.yaml#L10
[2] https://github.com/bitnami/charts/blob/main/bitnami/postgresql/templates/_helpers.tpl#L20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants