Skip to content

#315 Add namespaceOverride support to deploy Weaviate in a specific namespace#316

Open
jeffWild wants to merge 4 commits into
weaviate:mainfrom
jeffWild:main
Open

#315 Add namespaceOverride support to deploy Weaviate in a specific namespace#316
jeffWild wants to merge 4 commits into
weaviate:mainfrom
jeffWild:main

Conversation

@jeffWild
Copy link
Copy Markdown

Description:

Currently, the Helm chart deploys all resources into the namespace defined by the Helm release (via --namespace flag). However, it would be useful to have an option to override this behavior and explicitly specify a target namespace in the values.yaml.

Proposed solution:

Add a new optional value, e.g.:

namespaceOverride: ""

and below code in all resources:

metadata:
namespace: {{ default .Release.Namespace .Values.namespaceOverride }}
When this value is set (non-empty), all chart templates should use this namespace instead of .Release.Namespace.

Example usage:

namespaceOverride: "custom-namespace"

This allows teams with shared CI/CD pipelines or limited namespace permissions to deploy Weaviate into a specific namespace without having to rely solely on Helm CLI options. Also when integrating weaviate as a subchart, we could separate in another namespace than the rest of the chart.

Benefits:

Enables more flexible deployments in shared clusters

Simplifies automation in multi-tenant environments

Aligns with patterns used by many official Helm charts

Copy link
Copy Markdown

@orca-security-eu orca-security-eu Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot
Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

@jeffWild
Copy link
Copy Markdown
Author

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.beep boop - the Weaviate bot 👋🤖PS:Are you already a member of the Weaviate Forum?

I agree with the CLA ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants