#315 Add namespaceOverride support to deploy Weaviate in a specific namespace#316
Open
jeffWild wants to merge 4 commits into
Open
#315 Add namespaceOverride support to deploy Weaviate in a specific namespace#316jeffWild wants to merge 4 commits into
jeffWild wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
I agree with the CLA ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the Helm chart deploys all resources into the namespace defined by the Helm release (via --namespace flag). However, it would be useful to have an option to override this behavior and explicitly specify a target namespace in the values.yaml.
Proposed solution:
Add a new optional value, e.g.:
namespaceOverride: ""
and below code in all resources:
metadata:
namespace: {{ default .Release.Namespace .Values.namespaceOverride }}
When this value is set (non-empty), all chart templates should use this namespace instead of .Release.Namespace.
Example usage:
namespaceOverride: "custom-namespace"
This allows teams with shared CI/CD pipelines or limited namespace permissions to deploy Weaviate into a specific namespace without having to rely solely on Helm CLI options. Also when integrating weaviate as a subchart, we could separate in another namespace than the rest of the chart.
Benefits:
Enables more flexible deployments in shared clusters
Simplifies automation in multi-tenant environments
Aligns with patterns used by many official Helm charts