Skip to content

Conversation

@Dabz
Copy link

@Dabz Dabz commented Nov 12, 2025

This PR changes the retry logic of the client:

  • Adding a new customizable RetryConfig to specify a custom backoff, retry count and retry timeout
  • Ensuring that all gRPC calls are retried using this logic

The RetryConfig have the following parameters

  • request_retry_count: int = 20 - The maximum number of retry to be performed
  • request_retry_backoff_ms: int = 100 - The backoff time between each retry (exponential)
  • timeout_ms: int = 30000 - The maximum amount of time to retry

The retry loop is interrupted if the number of retry exceed the defined counter or if the amount of time retrying (including the method execution) exceed the configured timeout

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 83.78378% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.73%. Comparing base (a226ea5) to head (d933ab4).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/retry.py 66.66% 8 Missing ⚠️
weaviate/connect/v4.py 69.56% 7 Missing ⚠️
weaviate/config.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
- Coverage   86.86%   86.73%   -0.14%     
==========================================
  Files         273      273              
  Lines       19105    19760     +655     
==========================================
+ Hits        16596    17139     +543     
- Misses       2509     2621     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants