fix: enforce HTTPS scheme check in CheckAllowedOrigins fallback path#820
Merged
fix: enforce HTTPS scheme check in CheckAllowedOrigins fallback path#820
Conversation
…rigins fallback path The HTTPS scheme check was unreachable in the fallback path (no allowed origins configured) because the method returned early on host match. Move the check before host comparison so it is always enforced. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Break long CheckAllowedOrigins constructor calls into multi-line format - Regenerate PHPStan baseline to match current codebase state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove baseline entries for $optionStorage and $icon deprecations that no longer match reported errors in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckAllowedOrigins, where it was previously unreachable dead code$securedRelyingPartyIdparameter toCheckAllowedOriginsto allow exempting specific RP IDs from HTTPS enforcement (e.g.localhostin development)throwwhen neither host nor subdomain matches, replacing the former dead code path