fix: normalize host-only allowed origins to https:// scheme#822
Merged
fix: normalize host-only allowed origins to https:// scheme#822
Conversation
Host-only entries in allowed_origins (e.g. "example.com") were matched against the incoming origin's host without checking the scheme or port, allowing origins like https://example.com:8443 to bypass validation. Since WebAuthn requires TLS, host-only entries are now normalized to https://{host} in the constructor and go through the full origin match (scheme + host + port), closing this bypass. Fixes #817 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowed_origins(e.g.example.comwithout scheme) were matched only against the incoming origin's host, bypassing scheme and port validation. This allowed origins likehttps://example.com:8443orhttps://example.com:9999to pass validation when onlyexample.comwas configured.https://{host}in the constructor and go through the full origin match (scheme + host + port), closing this bypass.$hostOriginsproperty andisSubdomain()helper method are removed as they are no longer needed.Fixes #817
Test plan
spomky-labs.comwithallowSubdomains=truestill correctly match subdomains via full origin matchingexample.comin allowed_origins only matcheshttps://example.com(nothttps://example.com:8443orhttp://example.com)http://localhostexplicitly configured still works for development🤖 Generated with Claude Code