fix(u2c): make v1 handle negative host priorities #4621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses
u2c service will start returning -1 host priority values indicating that the host should not be used. the current services implementation does not correctly handle negative values.
by making the following changes
This is a bug fix, not a breaking change. The core logic is preserved:
homeCluster filtering - Still filters by host.homeCluster when no clusterId is provided
clusterId filtering - Still filters by host.id === clusterId when provided
Priority selection - Still selects the host with the lowest priority number (priority 1 > priority 5)
Failed host handling - Still resets failed flags when all hosts have failed
What the fix actually does
The only behavioral difference is for hosts with priority <= 0:
Before: A host with priority: -1 could "win" the reduce because -1 > undefined is false, and the comparison logic was flawed with the empty object {} initial value
After: Hosts with priority <= 0 are excluded upfront, and if no valid hosts remain, it falls back to defaultUrl
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.