fix(cc-sdk): relogin registration issue #4626
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rarajes2
left a comment
rarajes2
left a comment
There was a problem hiding this comment.
- Let's add a vidcast
- Add/Update the UTs
| * @returns {Promise<void>} | ||
| * @private | ||
| */ | ||
| private async handleDeviceType(deviceType: LoginOption, dn: string): Promise<void> { |
There was a problem hiding this comment.
I know this is not in the scope of this PR but let's discuss this method.
It's doing two different things but the name is bit misleading :
- Registering the device in case of BROWSER device type
- For other cases, it's simply setting the agent config which will be further used for the station login
| method: METHODS.SILENT_RELOGIN, | ||
| }); | ||
| await this.stationLogout({ | ||
| logoutReason: 'User requested agent device change', |
There was a problem hiding this comment.
Should we add the error message in the logout reason so, we can have actual reason ?
| module: CC_FILE, | ||
| method: METHODS.SILENT_RELOGIN, | ||
| }); | ||
| if (error.message.contains('Error registering web calling line')) { |
There was a problem hiding this comment.
Should we compare the device type and error code instead of error message ? Message can be added as comment for developer's readability
Kesari3008
left a comment
Kesari3008
left a comment
There was a problem hiding this comment.
Did we troubleshoot this issue in more details as to why Calling SDK is not getting the deviceURI and userID information after reload ?
I wouldn't suggest addding fix to deregister and register directly without the RCA
3 participants
COMPLETES #CAI-7496
This pull request addresses
We are getting relogin failures when we do the cc sdk relogin.
await this.webCallingService.registerWebCallingLine(); fails for relogin.
by making the following changes
Did the deregister and register when we fe this issue.
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.