fix: do not store errors, errors from files not included should not b…#298
Open
ricardogobbosouza wants to merge 1 commit intomainfrom
Open
fix: do not store errors, errors from files not included should not b…#298ricardogobbosouza wants to merge 1 commit intomainfrom
ricardogobbosouza wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
- Coverage 98.98% 98.94% -0.05%
==========================================
Files 7 7
Lines 297 284 -13
Branches 78 77 -1
==========================================
- Hits 294 281 -13
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #74
Summary
As soon as the lint is executed, the error results are stored in
new WeakMap.If the file is no longer used and is in storage, your error is recorded and it is necessary to restart it.
What kind of change does this PR introduce?
Error storage has been removed, there is no performance gain, just a bug
In short, if the file is not included in the graph, it should not be passed through the lint
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No