fix(security): 2 improvements across 2 files#992
Open
tomaioo wants to merge 2 commits intowebrecorder:mainfrom
Open
fix(security): 2 improvements across 2 files#992tomaioo wants to merge 2 commits intowebrecorder:mainfrom
tomaioo wants to merge 2 commits intowebrecorder:mainfrom
Conversation
- Security: TLS certificate verification disabled for outbound HTTP requests - Security: Unsanitized JSONP callback rewrite allows script injection in rewritten response Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: TLS certificate verification disabled for outbound HTTP requests - Security: Unsanitized JSONP callback rewrite allows script injection in rewritten response Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:pywb/warcserver/http.py:L12The custom HTTP adapter defaults to
cert_reqs='CERT_NONE', and warnings are globally suppressed viaurllib3.disable_warnings(). This disables server certificate validation for live/remote fetches, enabling man-in-the-middle attacks and silent interception/modification of fetched content.Solution
Enable certificate verification by default (
CERT_REQUIRED), configure trusted CA bundle/dir, and remove global warning suppression. If insecure mode is needed, gate it behind an explicit opt-in configuration flag with clear warnings.Changes
pywb/warcserver/http.py(modified)pywb/rewrite/jsonp_rewriter.py(modified)