fix(pg): auto-migrate schema on pg serve startup#252
Merged
Conversation
Run EnsureSchema before CheckSchemaCompat in pg serve so that missing tables (e.g. tool_result_events after upgrading from 0.16.x to 0.17.0) are created automatically. Read-only PG roles gracefully fall through to the compat check. Closes wesm#251 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
Change EnsureSchema error handling from warning-and-continue to fatal for non-read-only errors, preventing startup against a partially migrated schema. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureSchemabeforeCheckSchemaCompatinpg serveso missing tables (e.g.tool_result_eventsafter upgrading from 0.16.x to 0.17.0) are created automaticallyTestEnsureSchemaMigratesLegacySchemaintegration test that simulates a legacy schema upgradeCloses #251
Test plan
make testpassesmake test-postgrespasses (exercisesTestEnsureSchemaMigratesLegacySchema)pg servestarts without manual SQL🤖 Generated with Claude Code