Stop defining volumechange in terms of public API#12428
Merged
Conversation
cf4109f made it so that technically the muted content attribute and playing backwards would result in a volumechange event. That was not intentional. This restores those aspects to before that commit and also modernizes the editorial style of the concepts involved.
foolip
approved these changes
May 8, 2026
| getter steps are to return true if this is <span | ||
| data-x="concept-media-muted">muted</span>; otherwise false.</p> | ||
| <p>To <dfn export>set the muted state</dfn> of a <span>media element</span> <var>element</var> to | ||
| a boolean <var>value</var>:</p> |
Member
There was a problem hiding this comment.
Ah, nice solution, this algorithm only takes a boolean so the boolean → "default" cases cannot happen.
Member
|
I've written some additional tests in https://chromium-review.git.corp.google.com/c/chromium/src/+/7831199 which I think cover the main ways this could be buggy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf4109f made it so that technically the muted content attribute and playing backwards would result in a volumechange event. That was not intentional. This restores those aspects to before that commit and also modernizes the editorial style of the concepts involved.
(See WHATWG Working Mode: Changes for more details.)
/media.html ( diff )