Fix Analysis Sync in FEN import #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies Analysis Sync to fix a potential undesired behavior when importing FEN games.
Before:
Initital state has no moves, playing adds them to the analysis history. Going backwards destroys these moves until the user is left with no history.
After:
Initial state has no moves, playing adds them permanently to the analysis history. Going backwards maintains the created history. Playing other moves falls into "phantom" history, the same way as playing other moves in other import modes. Going backwards undo each "phantom" move until it reaches the permanent history.