fix(smoke): align with sdk_demo_backend spec#5
Merged
Merged
Conversation
Bring the smoke test in line with the canonical Asobi SDK smoke spec at
widgrensit/sdk_demo_backend (SMOKE.md):
- Default URL http://localhost:8080 -> http://localhost:8084
- Match mode "smoke" -> "demo"
- Header refs asobi-test-harness -> widgrensit/sdk_demo_backend
- Scenario 3: capture x_initial from the first match.state, send
{move_x: 1, move_y: 0}, then assert a subsequent state has
x > x_initial + 10. Replaces the literal x == 1 check, which would
trivially pass against sdk_demo_backend's random spawn x in [50, 700].
- CI workflow now clones widgrensit/sdk_demo_backend and runs
docker compose up -d, matching the reference snippet in SMOKE.md.
Taure
added a commit
that referenced
this pull request
May 2, 2026
Rewrites the README so it reflects what asobi-js actually is — a thin transport client for the asobi protocol — and drops the broad feature-table claims (worlds, terrain, voting, economy, leaderboards, etc.) that overstated coverage. Changes: - Add Scope and Status sections; mark typed REST helpers as deprecated for v1.0 - Replace REST-heavy quickstart with a WebSocket-only example using `AsobiWebSocket` - Add API reference block for `AsobiWebSocket` - Move engine/framework integrations (Phaser/Three/Pixi) to opt-in `examples/` rather than bundled exports - Remove the Features matrix that promised full coverage of unstable subsystems Rebase note: this PR was rebased onto main after #4/#5/#7/#8 landed. The README conflict was resolved by keeping the PR's narrowed-scope structure (Scope/Status/API/adapters sections, no Features table) while preserving main's factual updates that don't conflict with the narrowing: the Node 22+ header, the @widgrensit/asobi package name, the "Run a backend first" section pointing at sdk_demo_backend on :8084, the Browser usage section, and the canonical link to the WebSocket protocol guide. The PR's deletion of the Features matrix and REST-flavoured quickstart was preserved — that deletion is the whole point of the PR. No code change. Code refactor follows in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the smoke test in line with the canonical Asobi SDK smoke spec at widgrensit/sdk_demo_backend SMOKE.md.
http://localhost:8080->http://localhost:8084."smoke"->"demo".widgrensit/sdk_demo_backendinstead of the retiredasobi-test-harness.x_initialfrom the first observedmatch.state, sends onematch.input{move_x: 1, move_y: 0}, and asserts a subsequent state showsplayers[A].x > x_initial + 10. The previousx == 1literal check would trivially pass againstsdk_demo_backend, where players spawn at randomx in [50, 700]..github/workflows/smoke.ymlcloneswidgrensit/sdk_demo_backendand runsdocker compose up -d, matching the reference workflow snippet in SMOKE.md.Test plan
npm run buildpasses.tsxloadssmoke_tests/smoke.ts(it begins polling the backend).sdk_demo_backend.