Skip to content

fix(security): address 4 High findings from 2026-05-19 audit#125

Open
Taure wants to merge 4 commits into
mainfrom
security/highs-2026-05-19
Open

fix(security): address 4 High findings from 2026-05-19 audit#125
Taure wants to merge 4 commits into
mainfrom
security/highs-2026-05-19

Conversation

@Taure
Copy link
Copy Markdown
Contributor

@Taure Taure commented May 19, 2026

Closes the four High findings from the 2026-05-19 security audit.

Summary

  • H1 — WS chat.join / chat.send now route through asobi_chat_acl:authorized/2, the same predicate the HTTP history endpoint already uses. Without this, any authenticated player could silently join dm:<alice>:<bob> and eavesdrop on every DM between them.
  • H2 — New asobi_body_cap_plugin rejects HTTP bodies > 1 MiB and chunked requests without content-length, before nova_request_plugin buffers them into the BEAM heap. Per-route caps (e.g. 256 KB on saves) still apply on top.
  • H3asobi_world_lobby:list_worlds_cached/0,1 caches world.list results for 500 ms via an ETS table owned by asobi_world_lobby_server. Stops a 60 msg/sec WS flood from fanning out 60k synchronous get_info calls per second against running worlds. find_or_create_unsafe stays uncached.
  • H4 — Bump nova to 0.14.3 and add explicit cowboy override so cowlib resolves to 2.16.1. rebar3 audit now reports 1 vuln (LOW) down from 3 (with a HIGH on cowlib 2.16.0). The remaining LOW is pending an upstream cowlib release.

Test plan

  • rebar3 eunit — 274 tests, 0 failures (includes 11 new tests across asobi_chat_acl_tests, asobi_body_cap_plugin_tests, asobi_world_lobby_cache_tests)
  • rebar3 fmt --check clean
  • rebar3 xref clean
  • rebar3 dialyzer clean
  • elp eqwalize-all — 0 errors (down from 2 pre-existing in asobi_world_lobby_ws_SUITE, also fixed)
  • elp lint — no new warnings
  • rebar3 audit — 3 vulns → 1 (LOW) remaining
  • CT suite (requires Docker Postgres; runs in CI)

What is NOT in this PR

The audit's 10 Medium and 6 Low findings are deferred to a follow-up. Mediums worth flagging:

  • M1 (hash auth-cache key)
  • M3 (player metadata size cap)
  • M5 (put_storage size cap)
  • M6 (TLS pinning on Steam/Apple/Google httpc)
  • M4 ban-column story (decision needed: implement or remove)

Taure added 4 commits May 19, 2026 22:51
H1: WebSocket chat.join and chat.send now run asobi_chat_acl:authorized/2
before joining the pg group or forwarding the message. Without this check
any authenticated player could join dm:<alice>:<bob> via the WS path (the
HTTP /api/v1/chat history endpoint already enforced membership) and read
every subsequent DM between the two parties.

H2: New asobi_body_cap_plugin caps HTTP request body size to 1 MiB and
rejects chunked POSTs without content-length. Runs before
nova_request_plugin so oversized bodies are never buffered into BEAM heap.
Per-route caps (256 KB on saves, etc) remain on top of this floor.

H3: list_worlds_cached/0,1 backs WS world.list and the HTTP index route
with a 500 ms TTL cache owned by asobi_world_lobby_server. A 60 msg/sec
WS flood of world.list against 1000 worlds previously fanned out to 60k
synchronous get_info calls per second; the cache absorbs the fan-out
without breaking find_or_create_unsafe (which stays uncached).

H4: Bump nova to 0.14.3 and add explicit override on the cowboy package
so cowlib resolves to 2.16.1, clearing the rebar3 audit HIGH advisory
against 2.16.0. One LOW cowlib advisory remains pending an upstream
cowlib release.

Audit doc: docs/security_audit_2026_05_19.md.
GHSA-g2wm-735q-3f56 is a LOW-severity advisory against
cow_cookie:cookie/1 (cowlib) with no upstream patch on any released
cowlib version, and no patch on ninenines/cowlib master (only a doc
update). asobi never calls cow_cookie:cookie/1 — only setcookie via
cowboy_req — so the advisory does not apply to this codebase. Track
in docs/security_audit_2026_05_19.md.

Requires Taure/erlang-ci#62 (audit-ignores input). Temporarily pinned
to the feature branch SHA; Dependabot will repin to main after merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant