chore(test): remove stale class-API tests (closes #11)#13
Merged
Conversation
The test/ suite targeted a deleted class-based API and a flame_test version that has since changed shape, producing ~70 analyzer errors. Smoke test in smoke_tests/smoke.dart already provides end-to-end CI signal against sdk_demo_backend; widget tests for the new mixin API are a future task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
test/suite targeted a deleted class-based API and aflame_testversion that has since changed shape (gameTester.testis gone,MatchInputconstructor signature shifted to required-nameddown,PlayerBuilder/ProjectileBuildertypedefs changed).flutter analyzewas reporting ~42 errors plus dozens of dynamic-call infos. Closes #11.Decision per file
test/asobi_input_sender_test.dartgameTester.test+MatchInput(...)signatures broken; rewrite cost > value given smoke coverage existstest/asobi_matchmaker_test.darttest/asobi_network_sync_test.dartPlayerBuilder/ProjectileBuildertypedef shape changed; would need full rewritetest/asobi_player_test.dartwith AsobiPlayer); blocked bygameTester.testtest/asobi_projectile_test.dartNo file was a 5-minute port — the chosen direction is consistent with the issue's preferred fallback ("delete them and rely on the smoke test as the sole CI signal until proper widget tests exist").
A short
test/README.mdwas added documenting the testing strategy.Coverage gaps (follow-up)
smoke_tests/smoke.dartexercises the SDK contract surface (AsobiClient, realtime matchmaking,match.input->match.stateround-trip) but does not exercise any Flame-side mixin behavior:HasAsobiInput: keyboard tracking, mouse aim,inputSendIntervalbatchingHasAsobiMatchmaker:findMatch/cancelSearch/searchTimeaccumulation, lifecycle callbacksAsobiNetworkSync: player + projectile component create/remove fromMatchStatediffs, local player identification,onStateUpdate/onMatchFinishedcallbacksAsobiPlayermixin:initPlayer,applyServerState, lerp,isDead, label defaultsAsobiProjectilemixin:initProjectile,applyServerStatewithpixelsPerUnitProper widget tests for the mixin-based components are a future task and should be tracked separately.
flutter analyze
All 11 are pre-existing infos / one warning in
lib/,example/, andpubspec.yaml— zero errors, none introduced by this change.flutter test
Expected — CI signal now comes from
smoke_tests/smoke.dart.Test plan
flutter analyzereturns zero errorsflutter testruns cleanly (reports no test files, as designed)