Update Login test#19
Open
adydams wants to merge 6 commits into
Open
Conversation
wilforlan
requested changes
Jul 4, 2018
wilforlan
left a comment
wilforlan
left a comment
Owner
There was a problem hiding this comment.
You should not just expect a status 200, you should expect some properties and assert their types and check if they available to pass this test.
Also, you need to set a global token constant after a successful login
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action : Created the users_login files
Guide : The users_login. js file is use to run a TDD on the users' login functionality of user.controller.js file with frisby
global setup is kept
Date : 3rd July 2018