guarantor and view loan#20
Open
bosstha wants to merge 1 commit into
Open
Conversation
wilforlan
requested changes
Jul 4, 2018
wilforlan
left a comment
wilforlan
left a comment
Owner
There was a problem hiding this comment.
Also, make sure that your file is properly indented.
| const joi = frisby.joi | ||
|
|
||
| it ('POST should return a status of 201 Created', function () { | ||
| frisby.globalSetup({ |
Owner
There was a problem hiding this comment.
Incorrect Flow, you should be getting the token from the login endpoint. So I can test automatically.
| password: "miracle" | ||
| }) | ||
| .expect('status', 201); | ||
| .get('http://localhost:3000/loans/approve/,5b3b249b0d216645b40447aa') |
Owner
There was a problem hiding this comment.
Why is the comma here before the id ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TDD for guarantor approve and user view single and multiple loans.