Update disburse loan test#21
Open
adydams wants to merge 4 commits into
Open
Conversation
wilforlan
requested changes
Jul 4, 2018
| it ('POST should return a status of 200 OK', function (res) { | ||
| return frisby | ||
| .put('http://localhost:3000/loans/disburse/5b3c114131124a0d7415c640', { | ||
| amountDisbursed: 3500000 , |
Owner
There was a problem hiding this comment.
Are you posting amount disbursed and error message while disbursing the loan. If yes, Why ?
Contributor
Author
There was a problem hiding this comment.
The amount disbursed is to be posted by the admin. Peradventure, the total amount of loan requested cannot be disbursed a note is attached to disclose why the entire loan cannot be disbursed. The note will be null if all the amount is been disbursed
Contributor
Author
There was a problem hiding this comment.
It is not an error message. It is a short note attached to explain why all the loan cannot be disbursed
wilforlan
requested changes
Jul 4, 2018
| // Do setup first | ||
| frisby.globalSetup({ | ||
| request: { | ||
| headers: { |
Contributor
Author
There was a problem hiding this comment.
Please, I don't understand the concept of settable. But I wanted it to be globally accessible by my test that is why I made it a root file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action : Created the disburse_loan.js and test_config js files
Guide : The disburse_loan.js file is use to run a TDD on the update profile functionality of loan.controller.js file and the test_config js file is where the frisby and token global setup is. The test_config js is required in the disburse_loan.js file
Date : 3rdJuly 2018