Skip to content

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jan 30, 2026

https://wearezeta.atlassian.net/browse/WPB-23190


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

all values in kalium config are calculated at app startup but will be needed way later of never
for example

  1. isWebSocketEnabledByDefaultis used only when adding a new user aka login
  2. fileRestrictionState can be lazy calculated later when needed
  3. shouldEncryptData is only needed during init and no need to have it around all the time

Solutions

  1. remove isWebSocketEnabledByDefaultis since it is only used one time when logging in and it can be passed when needed
  2. fileRestrictionState and shouldEncryptData as lambdaz that will be evaluated lazely

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.49%. Comparing base (d5ef236) to head (2e237fb).

Files with missing lines Patch % Lines
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% 2 Missing ⚠️
...entication/login/sso/LoginSSOViewModelExtension.kt 0.00% 2 Missing ⚠️
...ion/code/CreateAccountVerificationCodeViewModel.kt 0.00% 2 Missing ⚠️
...d/ui/authentication/login/sso/LoginSSOViewModel.kt 0.00% 1 Missing ⚠️
...id/ui/newauthentication/login/NewLoginViewModel.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (20.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4553      +/-   ##
===========================================
- Coverage    48.50%   48.49%   -0.01%     
===========================================
  Files          575      575              
  Lines        19810    19818       +8     
  Branches      3311     3311              
===========================================
+ Hits          9609     9611       +2     
- Misses        9187     9193       +6     
  Partials      1014     1014              
Files with missing lines Coverage Δ
.../authentication/login/email/LoginEmailViewModel.kt 78.68% <100.00%> (+0.23%) ⬆️
...d/ui/authentication/login/sso/LoginSSOViewModel.kt 68.33% <0.00%> (ø)
...id/ui/newauthentication/login/NewLoginViewModel.kt 82.12% <0.00%> (ø)
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% <0.00%> (ø)
...entication/login/sso/LoginSSOViewModelExtension.kt 2.77% <0.00%> (-0.17%) ⬇️
...ion/code/CreateAccountVerificationCodeViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ef236...2e237fb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants