Skip to content

Conversation

@ohassine
Copy link
Member

@ohassine ohassine commented Jan 30, 2026

https://wearezeta.atlassian.net/browse/WPB-23209


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

App is crashing when trying to open Drive screen from burger menu

Solutions

Make isSearchByDefaultActive nullable as it's not needed in that screen

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested a review from sbakhtiarov January 30, 2026 15:03
@ohassine ohassine requested a review from yamilmedina January 30, 2026 15:03
@ohassine ohassine changed the base branch from develop to main January 30, 2026 15:19
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.50%. Comparing base (aedceaf) to head (80e7d11).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4554   +/-   ##
=======================================
  Coverage   48.50%   48.50%           
=======================================
  Files         575      575           
  Lines       19810    19810           
  Branches     3311     3311           
=======================================
  Hits         9609     9609           
  Misses       9187     9187           
  Partials     1014     1014           
Files with missing lines Coverage Δ
...com/wire/android/feature/cells/ui/CellViewModel.kt 51.98% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aedceaf...80e7d11. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants