[WPB-26754] Logout tests

[lizaveta-korshuk]

WPB-26754 [Desktop/QA] Write Logout tests

[zskhan]

I noticed open is added to package.json, but I couldn't find any imports or usages of it in this PR. Is this dependency actually needed, or was it added unintentionally?

[lizaveta-korshuk]

I was meant for testing deep links, it will be needed later, but I could remove it for now or leave it for future
It's added anyway but not explicitly

[zskhan]

Great then lets remove it for now and add it again when needed.

[arjita-mitra]

Modal Dismissal Not Tested

The "Cancel" button on the logout popup is created but never tested.
ESC key dismissal not tested.

[lizaveta-korshuk]

This logic is supposed to be tested on web, cancelButton has been added to have full functionality of the pop up available for future need

[arjita-mitra]

Sensing a possible race condition here

app.page = app.windows()[2] relies on window order
If windows are created/destroyed in different order, this breaks. Shall we Use app.waitForEvent('window') or more stable window tracking.

[lizaveta-korshuk]

The idea is that windows are already created and are not destroyed.
We are checking that (while being on the account A) clicking the logout option in the account's B context menu will trigger the focus on the account B. But then we still need to manually assign app.page to account B which has index 2 because it doesn't happen automatically

[lizaveta-korshuk]

Alternatively we could find a not active window, e.g. like this

const userBWindow = app.windows().find(win => win !== app.page && win.url().startsWith('http'));

if (userBWindow) {
app.page = userBWindow;
}

[arjita-mitra]

this is much better i think it finds the window by logic, not position and works regardless of window count or creation order.

Consider extracting this into a helper function since it might be useful in other tests.

export const switchToNonActiveWindow = async (app: App) => {
  const inactiveWindow = app.windows().find(
    win => win !== app.page && win.url().startsWith('http')
  );
  
  if (!inactiveWindow) {
    throw new Error('No inactive window found');
  }
  
  app.page = inactiveWindow;
};

[arjita-mitra]

clicking historyConfirmButton without checking if it's visible assumes the history confirmation modal always appears. Should run expect().toBeVisible() first.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud