remove unnecessary files#8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes generated protobuf files from version control and attempts to update the Go toolchain version. The primary goal is to exclude generated code (.pb.go and _grpc.pb.go files) from the repository, shifting the responsibility of code generation to build time or CI pipelines.
Key changes:
- Adds a
.backupproto file for token transfers - Attempts to upgrade Go from 1.23.4 to 1.24 with toolchain go1.24.6
- Removes all generated protobuf Go files from multiple packages
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| proto/stellar/v1/token_transfers.proto.backup | Adds a backup proto file with .backup extension (questionable practice) |
| go/gen/stellar/v1/token_transfers.pb.go | Removes generated protobuf code for stellar token transfers |
| go/gen/source/* | Removes all generated source service protobuf files |
| go/gen/processor/* | Removes all generated processor service protobuf files |
| go/gen/flow/v1/* | Removes all generated flow v1 service protobuf files |
| go/gen/consumer/* | Removes all generated consumer service protobuf files |
| go.mod | Updates Go version to non-existent 1.24 with toolchain go1.24.6 |
| go.sum | Adds dependency entry for stellar/go-stellar-sdk |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates Go dependencies and removes generated protocol buffer files from the repository. The most significant changes are the upgrade of the Go toolchain and the deletion of generated
.pb.gofiles, which suggests a shift to generating these files at build time or managing them outside of version control.Key changes include:
Dependency and Toolchain Updates:
go.modfrom 1.23.4 to 1.24, and specified the toolchain asgo1.24.6. This ensures the project uses a more recent Go toolchain with the latest features and security updates.Generated Code Cleanup:
go/gen/consumer/consumer_grpc.pb.go. This file contained all client/server interface definitions and related gRPC service registration code.go/gen/flow/v1/common.pb.go, including message definitions forCursorandResumeToken.These changes likely reflect a move to exclude generated files from version control, relying instead on local or CI-time code generation.