Update CONTRIBUTING.md for Cloudflare Workers deployment#14055
Conversation
- Replace Netlify references with Cloudflare Workers - Add 'Creating a Version Branch' section documenting the process for setting up versioned docs branches on new major releases
❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →
|
|
Preview deployment ✅ Deployment complete!
|
The wrangler-action defaults to wrangler 3.x which doesn't support wrangler.jsonc or the --preview-alias flag.
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Sounds good to me. I left a nit regarding the Cloudflare Dashboard as access is limited.
Not related to this PR, but you might want to give a look at the v7 PR to resolve conflicts #13872
For example I see:
<<<<<<< v7
"wrangler": "^4.99.0"
=======
"wrangler": "^4.88.0"
>>>>>>> main
It seems weird since both changes are recent. I don't know if there is a good reason for those two version to be so different.
| ### 3. In the Cloudflare dashboard | ||
|
|
||
| - After the first successful deploy, go to the Worker's settings (e.g. `docs-v7`) -> **Domains & Routes** and add the custom domain (e.g. `v7.docs.astro.build`). |
There was a problem hiding this comment.
nit: Unless this is useful for you (or anyone having access to Cloudflare), I'm not sure we need this? I mean we didn't have that for Netlify and people with access knew how to do it.
There was a problem hiding this comment.
Just thought it would be better to document somewhere rather than it be tribal knowledge that you have to ask about on Discord (mostly just didn't want to be the only one who knew how). But if you think it doesn't belong here, happy to remove.
There was a problem hiding this comment.
I just wasn't sure if it was intentional because unlike that of withastro/astro, this one mostly contains things for every contributor (ie. not maintainer specific guidance). So, no issue here, I don't mind keeping that here!
There was a problem hiding this comment.
Yeah this is not like a secret or anything, but just documentation for those with access. Would rather keep it, thanks!
The v3 action defaults to wrangler 3.x which doesn't support wrangler.jsonc or --preview-alias. The v4 action defaults to wrangler 4 natively.
2 participants
Updates the contributor manual to reflect the migration from Netlify to Cloudflare Workers:
mainbecomes a version branchThe version branch process is now:
wrangler.jsoncand the site URL inastro.config.tsdeploy.ymlonmain