Kotlin: Experimental. Benchmark for coroutines (decoding with parallel tasks)#68
Open
ignaciotcrespo wants to merge 13 commits into
Open
Kotlin: Experimental. Benchmark for coroutines (decoding with parallel tasks)#68ignaciotcrespo wants to merge 13 commits into
ignaciotcrespo wants to merge 13 commits into
Conversation
…the opposite. What happens is the performance of multiple parallel tasks is better than 1 single task. But the performance without using coroutines is better than 1 task using coroutines. Maybe there is a way to use parallel tasks in an optimal way without using coroutines, but not sure the performance will increase too much.
…ith size >= 40x24
Contributor
Author
|
@hangduykhiem @connyduck here the PR to play with coroutines |
Contributor
Author
|
Benchmark in Pixel 4, improvement ~40%, again only for big images Pixel 4, array + cachePixel 4, coroutines |
mrousavy
added a commit
to mrousavy/react-native-blurhash
that referenced
this pull request
Jul 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using coroutines to generate parts of the image in parallel shows a good performance but only for images >= 48x24, specially with 3 tasks.
Here the benchmark in my Galaxy A5. The performance increases 50% with 3 parallel tasks.
The result for 1 task is not using any coroutine.
To compare a benchmark result code without coroutines, you can use the branch https://github.com/ignaciotcrespo/blurhash/tree/benchmark-array-cacheEnabled
Galaxy A5, current version array + cache
Galaxy A5, using coroutines