Add a nicer way to access post from the comment list #25159
Conversation
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30551 | |
| Version | PR #25159 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 93957ca | |
| Installation URL | 6p996cqpe7om0 |
kean
force-pushed
the
task/replace-comment-header-view
branch
from
6b5a357 to
93957ca
Compare
|
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30551 | |
| Version | PR #25159 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 93957ca | |
| Installation URL | 6lkrgol5lv098 |
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
This fixes a Liquid Glass-related issue too, so it's a big win.
| subtitleLabel.textAlignment = .center | ||
| subtitleLabel.maximumContentSizeCategory = .extraLarge | ||
|
|
||
| let chevronImageView = UIImageView() |
There was a problem hiding this comment.
Something about the image seems off – I'm not sure if it's the text baseline or if it's not quite the right size.
Will it work with dynamic type with a hard-coded point size?
There was a problem hiding this comment.
The labels can only grow so much: subtitleLabel.maximumContentSizeCategory = .extraLarge. There isn't space in the navigation bar. Let me check again how well it looks with the maximum size.
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
Replaces the floating section header view – which can be pretty annoying – with a small button in the navigation bar. You get to this screen from the Notifications.
Before:
https://github.com/user-attachments/assets/1ad4ddaa-e6d7-4a83-88be-aa5b7d765bec
After:
https://github.com/user-attachments/assets/17c6cee1-cc37-468d-9644-8cd0ce6b64b2