chore(lint): enable clippy::panic#92
Merged
Merged
Conversation
Forbids explicit panic!() calls in production code. Unreachable match arms in tests converted to unreachable!() which is semantically precise and not caught by this lint. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the
clippy::panicrestriction lint, which forbids explicitpanic!()calls in production code and encouragesunreachable!()for genuinely unreachable match arms.Closes #91
Changes
Cargo.toml— addspanic = "deny"to[lints.clippy], consistent with the existingdbg_macroandtodoentries.src/cli_tests.rs,src/issue/adhoc_tests.rs,src/issue/adhoc_env_tests.rs— replacespanic!("unexpected …")in match fallback arms withunreachable!("unexpected …"). These arms cannot be reached during a passing test;unreachable!is the semantically correct macro and is not caught byclippy::panic.Verification
cargo clippy --testspasses with zero warnings or errors. The pre-push hook confirmed build ✓, clippy ✓, and 100 % coverage ✓.This pull request was opened by the Clippy lint improvements → issue + PR (Rust repos) → Slack routine of moadim. CC @tupe12334