Skip to content

[WIP] Add support for other SIPS2 APIs#9

Open
Jydett wants to merge 18 commits intoworldline:developfrom
Jydett:develop
Open

[WIP] Add support for other SIPS2 APIs#9
Jydett wants to merge 18 commits intoworldline:developfrom
Jydett:develop

Conversation

@Jydett
Copy link
Contributor

@Jydett Jydett commented Jan 20, 2022 •
edited
Loading

Hi, this WIP PR adds support to others SIPS2 API (only Office -> wallet for now)

  • This include a refactor to extract the common parts
  • The module common-payment-sdk is renamed common-sdk
  • A new module wallet-sdk is created

TODO

  • Refactor code base
  • Payement tests workings with refactor
  • Implements wallets methods (getWalletData & deletePaymentMean)
  • TU
  • Javadoc

Feedback appreciated !

w112739 added 7 commits January 20, 2022 17:09
[WIP] Add Wallet API and refactor common code
cc66607 
 - factorize common code in sdk-common
 - remove sdk-payment common

No javadoc yet
Merge branch 'master' into develop
45a4647
Merge branch 'develop' of https://github.com/Jydett/sips-sdk-java int…
5e5b37d 
…o worldline_develop

� Conflicts:
�	payment-sdk/build.gradle
[WIP] rebased to 1.4.4-SNAPSHOT
c40789b 
No javadoc yet
[WIP] Fix serialisation & seal computation
b817b12 
 - Seal computation now sort all fields of a class hierarchy instead of sorting on each class
 - Fix broken seal calculator tests
[WIP] Add all payment mean brand
f19a2e1
[WIP] Add Delete Payment Mean Request
7202f32
@CrlH
Copy link
Collaborator

CrlH commented Jan 21, 2022

Great work so far, @Jydett!

Couple remarks up until now

  • SIPS 1.0 is EOL and only ever sold in FR. I’d propose not to use any sips 2.0 references, as this will cause unneeded confusion

  • ING Home’Pay is discontinued by ING and will shortly be removed from SIPS

@Jydett
Copy link
Contributor Author

Jydett commented Jan 21, 2022 •
edited
Loading

Ok @CrlH thx for the feedback.
I'll remove the SIPS 2.0 references and ING HomePay.

A couple a unit tests and documentations and this should be ready to review :D

On a side note are you interested to add github actions to this project ? (this could be done in another PR if you are interested)

Jydett and others added 5 commits January 22, 2022 17:37
@Jydett
[WIP] Delete ING' HOMEPAY & remove ref to sips 2
789eb00
[WIP] Rename common sdk
af604f2 
 - fix javadoc
 - fix exception bad imports
 - remove unused code
 - add few tests
 - accept unknown response code
[WIP] Rename common sdk
f003d62 
 - fix javadoc
 - fix exception bad imports
 - remove unused code
 - add few tests
 - accept unknown response code
[WIP] Remove todos
70f56ee
Merge remote-tracking branch 'origin/develop' into develop
f558122
@Jydett Jydett marked this pull request as ready for review January 24, 2022 15:00
@Jydett
Copy link
Contributor Author

Jydett commented Jan 24, 2022

This si worth noting that this could be a major version since some imports and names changed

@Jydett
Copy link
Contributor Author

Jydett commented Jan 24, 2022

I've updated the readme without changing the version number since I'm not sure how you want to bump the lib version with this PR

w112739 added 3 commits February 25, 2022 18:36
Fix seal computation for response requests
f51f420 
 - YearMonth is correctly parsed in seal computation
 - Add s10TransactionReference for Sips1 retro-compatibility
 - Fix payment response parameters type
 - Offesetted type zone are now correctly parsed
Add support for unknown payement brand and mean
bfaa8ed
Add support for unknown payment brand and mean
a19dd5b 
Fix payment test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jydett @CrlH